test: add regression test for C2879853 POLYGON pad shapes - #369
Open
Koizain wants to merge 1 commit into
Open
Conversation
) Adds fixture and test to confirm POLYGON pad shapes are converted correctly. The POLYGON shape was added to the enum in PadSchema, and this test verifies the end-to-end conversion produces pcb_smtpad elements with shape='polygon'. Fixes tscircuit#240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #240
Problem
Part C2879853 failed to import from JLCPCB with:
Root Cause & Fix
Polygon pad support was already added to
PadSchema(inlib/schemas/package-detail-shape-schema.ts) and the conversion logic inconvertEasyEdaJsonToCircuitJsonalready handlesPOLYGON→pcb_smtpadwithshape: "polygon".Changes
tests/assets/C2879853.raweasy.json— raw EasyEDA fixture for the parttests/convert-to-soup-tests/c2879853-polygon-pads.test.ts— regression test that:pcb_smtpadwithshape=polygonTesting
bun test tests/convert-to-soup-tests/c2879853-polygon-pads.test.tsResult: 1 pass, 0 fail